[SSSD] [PATCH] Build cifs plugin depending on the existence of cifsidmap.h

Lukas Slebodnik lslebodn at redhat.com
Mon Nov 11 16:29:17 UTC 2013


On (04/11/13 10:36), Simo Sorce wrote:
>On Mon, 2013-11-04 at 16:21 +0100, Sumit Bose wrote:
>> On Mon, Nov 04, 2013 at 12:05:15PM +0100, Lukas Slebodnik wrote:
>> > On (01/11/13 18:41), Sumit Bose wrote:
>> > >Hi,
>> > >
>> > >with this patch it is not required anymore to have cifs-utils-devel
>> > >installed for the default build.
>> > >
>> > >Fixes https://fedorahosted.org/sssd/ticket/2125
>> > >
>> > >bye,
>> > >Sumit
>> > 
>> > >From 35f5932946d67a943146411a336afac34a78fb90 Mon Sep 17 00:00:00 2001
>> > >From: Sumit Bose <sbose at redhat.com>
>> > >Date: Fri, 1 Nov 2013 18:33:32 +0100
>> > >Subject: [PATCH] Build cifs plugin depending on the existence of cifsidmap.h
>> > >
>> > >To allow the "configure; make; make install" scheme on systems where
>> > >cifsidmap.h is not available the cifs-utils plugin is only build if the
>> > >include file is available and not build if it is not available.
>> > >
>> > >If the configure option --enable-cifs-idmap-plugin is used, configure
>> > >will fail if cifsidmap.h is not available.
>> > >
>> > >Fixes https://fedorahosted.org/sssd/ticket/2125
>> > >---
>> > > src/external/cifsidmap.m4 | 17 ++++++++++-------
>> > > 1 file changed, 10 insertions(+), 7 deletions(-)
>> > >
>> > >diff --git a/src/external/cifsidmap.m4 b/src/external/cifsidmap.m4
>> > >index 53cb8b7..fbcbe65 100644
>> > >--- a/src/external/cifsidmap.m4
>> > >+++ b/src/external/cifsidmap.m4
>> > >@@ -2,15 +2,18 @@ AC_ARG_ENABLE([cifs-idmap-plugin],
>> > >               [AS_HELP_STRING([--disable-cifs-idmap-plugin],
>> > >                               [do not build CIFS idmap plugin])],
>> > >               [build_cifs_idmap_plugin=$enableval],
>> > >-              [build_cifs_idmap_plugin=yes])
>> > >+              [build_cifs_idmap_plugin=auto])
>> > > 
>> > >-AS_IF([test x$build_cifs_idmap_plugin = xyes],
>> > >-      [AC_CHECK_HEADER([cifsidmap.h], [],
>> > >-                       [AC_MSG_ERROR([you must have the cifsidmap header installed to build the idmap plugin])])
>> > >-      ])
>> > 
>> > I have an idea. We can leave default value "yes" and extend AC_MSG_ERROR
>> > message. For example:
>> > "You can disable cifs plugin with parameter --disable-cifs-idmap-plugin"
>> > 
>> > Is it a bad idea?
>> 
>> I would like to hear Simo's opinion on both suggestions, before doing
>> any changes.
>
>As long as it is possible to build without the idmap plugin I do not
>really care what is the default, use your best judgment.
>The problem is in that not being an option, not in what we use as
>default.
>
>Simo.
>
>-- 
>Simo Sorce * Red Hat, Inc * New York
>

It was not clear that cifs-idmap plugin is optional feature of sssd.
At least, simo and user from sssd-users were confused.
https://lists.fedorahosted.org/pipermail/sssd-users/2013-October/001137.html

Attached patch changes only AC_MSG_ERROR.

LS
-------------- next part --------------
>From 5ec8feaeaaa7016cda505b75d5b9ac6f84fc6ef5 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Mon, 11 Nov 2013 17:07:34 +0100
Subject: [PATCH] BUILD: Change error message if missing cifsimap.h

cifs-idmap plugin is enabled by default, but required header file cifsidmap.h
needn't be available on other distributions. It was not clear that cifs-idmap
plugin is optional feature of sssd. With this patch, configure will recommend
to build sssd without cifs idmap plugin if cifsidmap.h is not available.

Resolves:
https://fedorahosted.org/sssd/ticket/2125
---
 src/external/cifsidmap.m4 | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/external/cifsidmap.m4 b/src/external/cifsidmap.m4
index 53cb8b778da9639a9d48c18ac9d86697325b8955..0aac8fa9d672290f457d2d907b58f7a66b79c20b 100644
--- a/src/external/cifsidmap.m4
+++ b/src/external/cifsidmap.m4
@@ -6,7 +6,10 @@ AC_ARG_ENABLE([cifs-idmap-plugin],
 
 AS_IF([test x$build_cifs_idmap_plugin = xyes],
       [AC_CHECK_HEADER([cifsidmap.h], [],
-                       [AC_MSG_ERROR([you must have the cifsidmap header installed to build the idmap plugin])])
+                       [AC_MSG_ERROR([
+You must have the cifsidmap header installed to build the idmap plugin.
+If you want to build sssd withoud cifsidmap plugin then specify
+--disable-cifs-idmap-plugin when running configure.])])
       ])
 
 AM_CONDITIONAL([BUILD_CIFS_IDMAP_PLUGIN],
-- 
1.8.3.1



More information about the sssd-devel mailing list