[SSSD] [Patch] Cmocka unit test patch for authtok module

Pallavi Jha pallavikumarijha at gmail.com
Sat Nov 9 13:59:46 UTC 2013


Hi

I have created the patch and attached it with this mail. Kindly review it.
I have commented some of the test as it fails(gives segmentation fault)
when authtoken is NULL. I think we should test tok for NULL before
accessing its elements. Please correct me if am wrong.

for example :

uint8_t *sss_authtok_get_data(struct sss_auth_token *tok)
{
    return tok->data;
}

This should be written as:

uint8_t *sss_authtok_get_data(struct sss_auth_token *tok)
{
    if(!tok) {
        return EINVAL;
    }
    return tok->data;
}

Thanking You,
Pallavi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20131109/dc44dea0/attachment.html>


More information about the sssd-devel mailing list