[SSSD] [PATCH] Initialize sid_str to NULL to avoid freeing random data
Jakub Hrozek
jhrozek at redhat.com
Thu Nov 7 11:02:12 UTC 2013
See attached patch.
-------------- next part --------------
>From 0957bde0017f8ed2a5737f5de3af518ce588c004 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Thu, 7 Nov 2013 12:00:43 +0100
Subject: [PATCH] Initialize sid_str to NULL to avoid freeing random data
If any function before failed, sss_idmap_free_sid() might have been
called with random data.
---
src/providers/ad/ad_subdomains.c | 2 +-
src/providers/ldap/sdap_async_initgroups_ad.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/providers/ad/ad_subdomains.c b/src/providers/ad/ad_subdomains.c
index 45e7cc6579d54c36b87fb1f5b388c6c7d1a5b6d4..73190faa1e7e995123f12e2200ab00fb40f3b256 100644
--- a/src/providers/ad/ad_subdomains.c
+++ b/src/providers/ad/ad_subdomains.c
@@ -104,7 +104,7 @@ ad_subdom_store(struct ad_subdomains_ctx *ctx,
errno_t ret;
enum idmap_error_code err;
struct ldb_message_element *el;
- char *sid_str;
+ char *sid_str = NULL;
uint32_t trust_type;
bool mpg;
diff --git a/src/providers/ldap/sdap_async_initgroups_ad.c b/src/providers/ldap/sdap_async_initgroups_ad.c
index aa72c8876ba93eefc6230537801c50ab04e591ce..e58d93fb2da36febd6074381882192ba9e204e86 100644
--- a/src/providers/ldap/sdap_async_initgroups_ad.c
+++ b/src/providers/ldap/sdap_async_initgroups_ad.c
@@ -361,7 +361,7 @@ sdap_get_ad_tokengroups_initgroups_lookup_done(struct tevent_req *subreq)
size_t user_count, group_count, i;
TALLOC_CTX *tmp_ctx;
bool in_transaction = false;
- char *sid_str;
+ char *sid_str = NULL;
gid_t gid;
time_t now;
struct sss_domain_info *group_domain;
--
1.8.4.2
More information about the sssd-devel
mailing list