[SSSD] [PATCHES] idmap: add API to free allocated SIDs

Stephen Gallagher sgallagh at redhat.com
Mon Nov 4 19:46:55 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/04/2013 09:47 AM, Lukas Slebodnik wrote:
> On (04/11/13 15:40), Jakub Hrozek wrote:
>> On Mon, Nov 04, 2013 at 03:03:04PM +0100, Sumit Bose wrote:
>>> On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote:
>>>> https://fedorahosted.org/sssd/ticket/2133
>>> 
>>> Patches are looking good, I wonder why you did not cover binary
>>> SIDs, i.e. *_to_bin_sid() calls?
>>> 
>>> bye, Sumit
>> 
>> I would also prefer not to commit the last patch until the time
>> of release to avoid having to bump the version info if we did
>> more changes to the library.
> 
> I agree. version-info should be updated only once before official
> release, but we can add TODO comment into Makefile.am. "#TODO:
> update version-info before release"

In order to track these sorts of changes, perhaps just file an
upstream blocker ticket targeted at the release to make sure it gets
remembered?

It's pretty easy to miss a TODO in a file we only read rarely.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlJ3+a8ACgkQeiVVYja6o6NSQwCfY6Snav7NVa8NFKXH1pKZuAe8
7scAnjZoxiXJEqvsV0oLkFD+CFcgCGQ4
=KaIv
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list