[SSSD] [PATCH] build: fix ordering of linker flags

Stephen Gallagher sgallagh at redhat.com
Mon Nov 4 12:54:58 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/04/2013 05:45 AM, Jakub Hrozek wrote:
> On Sat, Nov 02, 2013 at 01:38:53AM +0100, Jan Engelhardt wrote:
>> 
>> On Saturday 2013-11-02 01:35, Dmitri Pal wrote:
>>> On 11/01/2013 08:13 PM, Jan Engelhardt wrote:
>>>> Libraries MUST be specified in LDADD/LIBADD, not LDFLAGS,
>>>> because LDFLAGS appear earlier in the command line and
>>>> library order is significant.
>>> 
>>> Thanks for a contribution. Can you please use git format-patch
>>> and attach patch to the email?
>> 
>> Humm this was sent by git-send-email which uses
>> git-format-patch. Alternatively you can grab it via
>> 
>> 
>> The following changes since commit
>> 64cb81a65e584858dd631bc5160959d350c091e3:
>> 
>> AD: Fix ad_access_filter parsing with empty filter (2013-10-30
>> 22:45:42 +0100)
>> 
>> are available in the git repository at:
>> 
>> git://git.inai.de/sssd master
>> 
>> for you to fetch changes up to
>> c9b13c7e032fde96cf07c7d298bb7fa65fad220b:
>> 
>> build: fix ordering of linker flags (2013-11-01 23:01:09 +0100)
>> 
>> ---------------------------------------------------------------- 
>> Jan Engelhardt (1): build: fix ordering of linker flags
>> 
>> Makefile.am | 69
>> ++++++++++++++++++++++++++++++++----------------------------- 1
>> file changed, 36 insertions(+), 33 deletions(-)
> 
> Thanks for the patch, it looks good to me (LDADD and LIBADD used
> as appropriate) and a test build went fine on Fedora 20 and RHEL6
> (multiple architectures).
> 
> So ack from me.
> 
> But I must say I'm not the biggest libtool or autotools expert, so
> I'd like to see one more ack from another developer.
> 
> Thanks again for the contribution!


Ack.

Absolutely correct. We've been doing this wrong for quite a while. Thanks!


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlJ3mSIACgkQeiVVYja6o6OkTwCggLXp/rxkZ/daR6CI850rzFqE
IyoAn20T7lxEq7BHd4TyXU2eB1VTDSna
=PYpk
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list