[SSSD] [PATCH] Enhance PAC responder for AD users

Jakub Hrozek jhrozek at redhat.com
Fri May 31 14:29:13 UTC 2013


On Fri, May 31, 2013 at 11:19:24AM +0200, Sumit Bose wrote:
> On Fri, May 31, 2013 at 10:32:34AM +0200, Lukas Slebodnik wrote:
> > On (22/05/13 14:54), Sumit Bose wrote:
> > >now with patches.
> > >
> > >On Wed, May 22, 2013 at 02:53:15PM +0200, Sumit Bose wrote:
> > >> Hi,
> > >> 
> > >> this patch makes sure that the PAC responder can be used with the AD
> > >> provider as well and so should fix
> > >> https://fedorahosted.org/sssd/ticket/1558. It depends on the SID mapping
> > >> patches.
> > >> 
> > >> It turned out that major parts of the PAC responder had to removed or
> > >> changed. E.g. all functions which were tested by the PAC responder unit
> > >> test got removed and hence the unit test is removes as well.
> > >> 
> > >> If tested the patch with IPA and AD provider. But since I certainly did
> > >> not cover all the corner cases (and maybe even missed some common
> > >> cases :-) I didn't enable the PAC responder for the AD provider by
> > >> default. But this can be done easily with an additional patch later.
> > >> 
> > >> bye,
> > >> Sumit
> > 
> > The socond patch could not be applied to current master.
> > 
> > error: patch failed: Makefile.am:135
> > error: Makefile.am: patch does not apply
> > error: patch failed: src/responder/pac/pacsrv_cmd.c:195
> > error: src/responder/pac/pacsrv_cmd.c: patch does not apply
> > error: patch failed: src/responder/pac/pacsrv_utils.c:765
> > error: src/responder/pac/pacsrv_utils.c: patch does not apply
> 
> Thanks for the hint, rebased versions attached.
> 
> bye,
> Sumit

Hi,

I still couldn't apply patch #2 cleanly with git am (not even with
three-way-merge). I was able to apply it manually using patch to proceed
with the review, though.



More information about the sssd-devel mailing list