[SSSD] [PATCHES] Add SID related lookups to the NSS responder - part 3

Jakub Hrozek jhrozek at redhat.com
Mon May 27 17:55:15 UTC 2013


On Tue, May 14, 2013 at 06:07:05PM +0200, Jakub Hrozek wrote:
> On Mon, May 13, 2013 at 12:33:46PM +0200, Sumit Bose wrote:
> > +    if (el->values[0].length > 2 &&
> > +        el->values[0].data[0] == 'S' &&
> > +        el->values[0].data[1] == '-')
> > +    {
> 
> Ack I will just reformat this opening bracket to conform to our coding
> guidelines.

By the way I was thinking about coding style with respect to multi-lined
conditional statements and I see the point in using this style, I just
don't like this particular implementation :-) It's sometimes hard to see
where the conditional ends and the code inside the block beings.

I wonder if an empty space (which I saw Ondra using) would help with
cases like this in the future?

if (hungry == true &&
    has_food == true) {

    eat();
}



More information about the sssd-devel mailing list