[SSSD] [PATCHES] Add SID related lookups to the NSS responder - part 3

Jakub Hrozek jhrozek at redhat.com
Mon May 27 16:58:23 UTC 2013


On Wed, May 22, 2013 at 02:10:11PM +0200, Sumit Bose wrote:
> On Tue, May 14, 2013 at 06:07:05PM +0200, Jakub Hrozek wrote:
> > On Mon, May 13, 2013 at 12:33:46PM +0200, Sumit Bose wrote:
> > > Hi,
> > > 
> > > with these four patches the SID-to-name API can now also be used with
> > > the AD provider and for local IPA accounts. Since this goes beyond the
> > > functionality needed by the FreeIPA WebUI I send them in a separate
> > > series. The patches are also a requirement for using the PAC with the AD
> > > provider (https://fedorahosted.org/sssd/ticket/1558).
> > > 
> > > bye,
> > > Sumit
> > 
> > [PATCH 1/4] IPA: Always initialize ID mapping
> > >      sdap_auth_ctx->service = ipa_options->service->sdap;
> > >      ipa_options->auth_ctx->sdap_auth_ctx = sdap_auth_ctx;
> > >  
> > > -    ret = ipa_get_id_options(ipa_options, bectx->cdb, bectx->conf_path,
> > > -                             &sdap_auth_ctx->opts);
> > > -    if (ret != EOK) {
> > > +    if (ipa_options->id == NULL) {
> > > +        ret = EINVAL;
> > >          goto done;
> > >      }
> > > +    sdap_auth_ctx->opts = ipa_options->id;
> > >  
> > 
> > Ack, I would just like to move all assignments to sdap_auth_ctx together
> > and then assign to ipa_options->auth_ctx for better readability.
> 
> Hi Jakub,
> 
> thank you for the review. I have fixed all your comments, new versions
> attached.
> 
> bye,
> Sumit

ACK to all patches.



More information about the sssd-devel mailing list