[SSSD] [PATCH] Adding script to create a SRPM

Sumit Bose sbose at redhat.com
Wed May 22 07:16:43 UTC 2013


On Wed, May 22, 2013 at 08:24:08AM +0200, Lukas Slebodnik wrote:
> ehlo,
> 
> Recommended way to create SRPM is to run make (prerelease-)srpm.
> But in previous case make file have to be generated, therefore
> configure script should not fail. (all sssd required dependencies have to be
>         installed)
> Script make_srpm.sh can be runned without running configure, script can be
> runned only from git repository.
> 
> https://fedorahosted.org/sssd/ticket/1927
> 
> Patch is attached.

Hi Lukas,

I haven't tested the script yet, nevertheless I have two comments. Please
add a copyright notice and a licence. Additionally I think '--define
_source_filedigest_algorithm=1' should be switch on by an option. Iirc
we added it because RHEL5 could not handle newer hash algorithms here.
But on newer platforms we should use the platform defaults.

bye,
Sumit

> 
> LS



More information about the sssd-devel mailing list