[SSSD] [PATCH] Fixing critical format string issues.

Lukas Slebodnik lslebodn at redhat.com
Fri May 17 17:29:01 UTC 2013


On (17/05/13 18:50), Lukas Slebodnik wrote:
>ehlo,
>
>This week Ondra fix segfault, which was caused by missing argument
>in debug message.
>>             ("nsupdate_get_addrs_done failed: [%d]: [%s]\n",
>>               sss_strerror(ret)));
>
>I was working on another ticket and I spotted similar bug.
>So I decided to enable printf format checking in debug_fn.
>There was a huge number of warnings. Attached patch fixes the most critical.
>--missing argument(s).
>--format '%s', but argument is integer.
>--wrong format string, example: '%\n'
>
>There are another 150 warnings, but they aren't critical.
>for example:
>format '%d' expects argument of type 'int', but argument 2 has type 'size_t'
>
I forgot to wrote in the first mail:
Remaining warnings are not critical, but they are. So I don't want to pollute
output from compiler with warnings, therefore patch did not enable
printf format checking in debug_fn.

LS



More information about the sssd-devel mailing list