[SSSD] [PATCH] Remove unneeded parameter of setup_child and namespace it

Jakub Hrozek jhrozek at redhat.com
Wed May 15 09:54:53 UTC 2013


A fix for a minor issue I found while looking at the module initialization.
-------------- next part --------------
>From b54ff0bb5ef0aa746522b3034f05b94182c94708 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Tue, 14 May 2013 18:55:40 +0200
Subject: [PATCH] Remove unneeded parameter of setup_child and namespace it

setup_child() was accepting a parameter it didn't use. Also the function
name was too generic, so I added a sdap prefix.
---
 src/providers/ad/ad_init.c              | 2 +-
 src/providers/ipa/ipa_init.c            | 2 +-
 src/providers/ldap/ldap_common.h        | 2 +-
 src/providers/ldap/ldap_init.c          | 2 +-
 src/providers/ldap/sdap_child_helpers.c | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/providers/ad/ad_init.c b/src/providers/ad/ad_init.c
index a7b0e702bef2c61c9f5483d003c05a52bae33370..b501cfb385ddfc577623bf5bc6d27e1ad843d974 100644
--- a/src/providers/ad/ad_init.c
+++ b/src/providers/ad/ad_init.c
@@ -174,7 +174,7 @@ sssm_ad_id_init(struct be_ctx *bectx,
         goto done;
     }
 
-    ret = setup_child(sdap_ctx);
+    ret = sdap_setup_child();
     if (ret != EOK) {
         DEBUG(SSSDBG_FATAL_FAILURE,
               ("setup_child failed [%d][%s].\n",
diff --git a/src/providers/ipa/ipa_init.c b/src/providers/ipa/ipa_init.c
index 5192bc81f4a7b5f298447da5a9f813af18e1fbb2..0a5d6e582b6e4eb1061f1162247208570bfdfc0e 100644
--- a/src/providers/ipa/ipa_init.c
+++ b/src/providers/ipa/ipa_init.c
@@ -197,7 +197,7 @@ int sssm_ipa_id_init(struct be_ctx *bectx,
         goto done;
     }
 
-    ret = setup_child(sdap_ctx);
+    ret = sdap_setup_child();
     if (ret != EOK) {
         DEBUG(1, ("setup_child failed [%d][%s].\n",
                   ret, strerror(ret)));
diff --git a/src/providers/ldap/ldap_common.h b/src/providers/ldap/ldap_common.h
index 86079fa6ad2aedcf220d38251adc94d60d654bd1..2d17b755808e58831b458bcc86a50eb74b1f1057 100644
--- a/src/providers/ldap/ldap_common.h
+++ b/src/providers/ldap/ldap_common.h
@@ -186,7 +186,7 @@ errno_t
 services_get_recv(struct tevent_req *req, int *dp_error_out);
 
 /* setup child logging */
-int setup_child(struct sdap_id_ctx *ctx);
+int sdap_setup_child(void);
 
 
 errno_t string_to_shadowpw_days(const char *s, long *d);
diff --git a/src/providers/ldap/ldap_init.c b/src/providers/ldap/ldap_init.c
index 0884a85c7d9db2c7c777caf0baebf59217076982..11b6486bcf687d15048b18136e03629915132514 100644
--- a/src/providers/ldap/ldap_init.c
+++ b/src/providers/ldap/ldap_init.c
@@ -164,7 +164,7 @@ int sssm_ldap_id_init(struct be_ctx *bectx,
         goto done;
     }
 
-    ret = setup_child(ctx);
+    ret = sdap_setup_child();
     if (ret != EOK) {
         DEBUG(1, ("setup_child failed [%d][%s].\n",
                   ret, strerror(ret)));
diff --git a/src/providers/ldap/sdap_child_helpers.c b/src/providers/ldap/sdap_child_helpers.c
index c63c3cb725c596f3203c017ab0d9891ed8d3248e..fd4d10f469c565af72441babcb365b2677ff28d4 100644
--- a/src/providers/ldap/sdap_child_helpers.c
+++ b/src/providers/ldap/sdap_child_helpers.c
@@ -450,7 +450,7 @@ static errno_t set_tgt_child_timeout(struct tevent_req *req,
 
 
 /* Setup child logging */
-int setup_child(struct sdap_id_ctx *ctx)
+int sdap_setup_child(void)
 {
     int ret;
     FILE *debug_filep;
-- 
1.8.2.1



More information about the sssd-devel mailing list