[SSSD] [PATCH] INI: Bump version-info

Jakub Hrozek jhrozek at redhat.com
Mon May 13 16:01:18 UTC 2013


On Mon, May 13, 2013 at 05:43:34PM +0200, Lukas Slebodnik wrote:
> On (07/05/13 10:34), Ondrej Kos wrote:
> >On 05/06/2013 01:58 PM, Lukas Slebodnik wrote:
> >>On (06/05/13 11:44), Ondrej Kos wrote:
> >>>Hi,
> >>>
> >>>https://fedorahosted.org/sssd/ticket/1908
> >>>Patch is attached.
> >>>
> >>>Ondra
> >>>--
> >>>Ondrej Kos
> >>>Associate Software Engineer
> >>>Identity Management
> >>>Red Hat Czech
> >>
> >>>From c42187dbbec1380ed632782315226220385b2af7 Mon Sep 17 00:00:00 2001
> >>>From: Ondrej Kos <okos at redhat.com>
> >>>Date: Mon, 6 May 2013 11:41:50 +0200
> >>>Subject: [PATCH] INI: Bump version-info
> >>>
> >>>https://fedorahosted.org/sssd/ticket/1908
> >>>---
> >>>Makefile.am | 2 +-
> >>>1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>>diff --git a/Makefile.am b/Makefile.am
> >>>index 3045ac5ce18e08f09faebce569f89893135e4b04..69f761474a464623e1082c945ee74fe9377fcfc4 100644
> >>>--- a/Makefile.am
> >>>+++ b/Makefile.am
> >>>@@ -245,7 +245,7 @@ libini_config_la_LIBADD = \
> >>>     libref_array.la \
> >>>     libbasicobjects.la
> >>>libini_config_la_LDFLAGS = \
> >>>-    -version-info 3:0:0
> >>>+    -version-info 4:0:1
> >>>
> >>>dist_noinst_DATA += \
> >>>     ini/ini.conf \
> >>>--
> >>>1.8.1.4
> >>>
> >>
> >>Public interface haven't been removed or changed since last public
> >>release libini_config-0.7.0-12 (File ini_config.h is unchanged).
> >>Only new functions have been added into new header files (ini/ini_configobj.h
> >>ini/ini_valueobj.h ini/ini_comment.h)
> >>
> >>Ack
> >>
> >>LS
> >>_______________________________________________
> >>sssd-devel mailing list
> >>sssd-devel at lists.fedorahosted.org
> >>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >>
> >
> >Pushed to master
> >
> 
> I might to write this email to separated thread, but I decided to write it
> here, because it is little bit related.
> 
> I tested all combinations of
> {libini_config-0.7.0-12,  libini_config-1.0.0.1-17} x {sssd(master), sssd(sssd-1-9)}
> 
> sssd master can be compiled with newer version of libini_config and can use new
> added functions. Version of libini_config is detected in configure.
> 
> All combinations works fine. The problem is with rpm dependencies.
> ssd(master) compiled with libini_config-1.0.0.1-17 requires:
>     rpm --requires -qp ./sssd-1.9.93.fc19.x86_64.rpm | grep ini
>     libini_config.so.3()(64bit)
> 
> Upgrade from f18 -> f19:
> sssd-1.9.4 will be upgraded to sssd-1.10.0, but libini_config will not be
> upgraded.
> 
> So even if libini_config-1.0.0.1-17 has soname libini_config.so.3.1.0
> only major version si automatically detected by rpm.

Thanks for testing! We know we don't have to rebuild the dependant
packages now.

> 
> Therefore we have to explicitly add requirements "libini_config >= 1.0.0.1"
> into spec file for f19.

Already fixed in F-19: eda364402d9a904f6a018e5d37bd8f743d27e2dd and
rawhide: a0794d8e0f7f60ca7bb3ee402b6b14d4c5957047

I'm wondering whether to also include the same for upstream spec file.
On one hand, I don't want to impose latest ding-libs on anyone who would
like to simply run "make rpms" on RHEL6 for example, on the other hand,
the initial reports came from people who simply grabbed an RPM intended
for F-19 and ran it on F-18. Maybe include the Require for F-19+ only?



More information about the sssd-devel mailing list