[SSSD] [PATCH] Fix missing initialization in Python bindings for libsss_nss_idmap

Sumit Bose sbose at redhat.com
Wed May 8 08:12:10 UTC 2013


Hi,

while testing other siff I came across this issue. It does not affect
the FreeIPA SID-to-name lookups but should be fixed anyways.

bye,
Sumit
-------------- next part --------------
From d6105fc0590b33ecf53a0101bee962b60786410c Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Wed, 8 May 2013 09:30:08 +0200
Subject: [PATCH] Fix missing initialization in Python bindings for
 libsss_nss_idmap

If sss_nss_getsidbyid() fails free() will try to work on an
uninitialized value.
---
 src/python/pysss_nss_idmap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/python/pysss_nss_idmap.c b/src/python/pysss_nss_idmap.c
index dd1fb4c..c98054e 100644
--- a/src/python/pysss_nss_idmap.c
+++ b/src/python/pysss_nss_idmap.c
@@ -113,7 +113,7 @@ static int do_getsidbyid(PyObject *py_result, PyObject *py_id)
     long id;
     const char *id_str;
     char *endptr;
-    char *sid;
+    char *sid = NULL;
     int ret;
     enum sss_id_type id_type;
 
-- 
1.7.7.6



More information about the sssd-devel mailing list