[SSSD] [PATCH] AD: Always initialize ID mapping

Jakub Hrozek jhrozek at redhat.com
Fri May 3 10:03:14 UTC 2013


I'm sorry, it looks like I didn't test one of the recent patches
properly and it was causing sssd_be crash when ID mapping was off in the
AD provider.
-------------- next part --------------
>From 11f1eb728d38f959de1cb71e57156e338a07993b Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Fri, 3 May 2013 10:00:37 -0400
Subject: [PATCH] AD: Always initialize ID mapping

Because we now always store SIDs in the LDAP provider, we also need to
always initialize the ID mapping context even if ID mapping itself is
off.
---
 src/providers/ad/ad_init.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/providers/ad/ad_init.c b/src/providers/ad/ad_init.c
index 4d10986895715fc51f48d0f88ab76912ee9e2796..224c98814216642344a5e6195601bd9da1b123e4 100644
--- a/src/providers/ad/ad_init.c
+++ b/src/providers/ad/ad_init.c
@@ -160,11 +160,9 @@ sssm_ad_id_init(struct be_ctx *bectx,
         goto done;
     }
 
-    if (dp_opt_get_bool(sdap_ctx->opts->basic, SDAP_ID_MAPPING)) {
-        /* Set up the ID mapping object */
-        ret = sdap_idmap_init(sdap_ctx, sdap_ctx, &sdap_ctx->opts->idmap_ctx);
-        if (ret != EOK) goto done;
-    }
+    /* Set up the ID mapping object */
+    ret = sdap_idmap_init(sdap_ctx, sdap_ctx, &sdap_ctx->opts->idmap_ctx);
+    if (ret != EOK) goto done;
 
     ret = sdap_id_setup_tasks(sdap_ctx);
     if (ret != EOK) {
-- 
1.8.2.1



More information about the sssd-devel mailing list