[SSSD] [PATCH] Do not copy special files when creating homedir

Ondrej Kos okos at redhat.com
Thu Jun 27 11:09:46 UTC 2013


On 06/27/2013 12:48 PM, Pavel Březina wrote:
> On 06/26/2013 03:16 PM, Ondrej Kos wrote:
>> Hi,
>>
>> Attached find a patch addressing sssd trac issue
>> https://fedorahosted.org/sssd/ticket/1778
>>
>> Ondra
>
> The patch works as expected, I have just a comment to debug message.
>
>> +        /* Is a special file */
>> +        DEBUG(SSSDBG_FUNC_DATA, ("Cannot copy '%s', it is a special
>> file.\n",
>> +                  src_ent_path));
>
> "Cannot copy" looks like this is something unexpected, an error. I'd
> recommend to use something like "'%s' is a special file, skipping...".
>

Thanks for the review, new patch is attached.

Ondra
-- 
Ondrej Kos
Associate Software Engineer
Identity Management - SSSD
Red Hat Czech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Do-not-copy-special-files-when-creating-homedir.patch
Type: text/x-patch
Size: 5532 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130627/51411f4d/attachment.bin>


More information about the sssd-devel mailing list