[SSSD] [PATCH] IPA: Do not download or store the member attribute of host groups

Jakub Hrozek jhrozek at redhat.com
Sun Jun 23 19:12:01 UTC 2013


The attached patch applies on both master and sssd-1-9 and fixes:
https://fedorahosted.org/sssd/ticket/1806

The IPA provider attempted to store the original value of member attribute
to the cache. That caused the memberof plugin to process the values which
was really CPU intensive.

We don't use the values anywhere and rely on the originalDN instead, so
it's safe to avoid even downloading them.

Many thanks to Andreas and Simo for their help debugging the problem.
-------------- next part --------------
>From a5f7da81a535b93f5faaf81c34342be6d8f05353 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Fri, 21 Jun 2013 20:00:39 +0200
Subject: [PATCH] IPA: Do not download or store the member attribute of host
 groups

https://fedorahosted.org/sssd/ticket/1806

The IPA provider attempted to store the original value of member
attribute to the cache. That caused the memberof plugin to process the
values which was really CPU intensive.
---
 src/providers/ipa/ipa_common.h | 1 -
 src/providers/ipa/ipa_opts.h   | 1 -
 2 files changed, 2 deletions(-)

diff --git a/src/providers/ipa/ipa_common.h b/src/providers/ipa/ipa_common.h
index 88728133f3d07292751c1a9c2e94fe3a3586d676..329306ef3873e14570ed2721b3e37ee2a735d6f4 100644
--- a/src/providers/ipa/ipa_common.h
+++ b/src/providers/ipa/ipa_common.h
@@ -83,7 +83,6 @@ enum ipa_host_attrs {
 enum ipa_hostgroup_attrs {
     IPA_OC_HOSTGROUP = 0,
     IPA_AT_HOSTGROUP_NAME,
-    IPA_AT_HOSTGROUP_MEMBER,
     IPA_AT_HOSTGROUP_MEMBER_OF,
     IPA_AT_HOSTGROUP_UUID,
 
diff --git a/src/providers/ipa/ipa_opts.h b/src/providers/ipa/ipa_opts.h
index ff161689ec2e7cb8ed8906110c9151343e9685d1..07960c90d7901e3c98005dbf261403cfa0d017bb 100644
--- a/src/providers/ipa/ipa_opts.h
+++ b/src/providers/ipa/ipa_opts.h
@@ -224,7 +224,6 @@ struct sdap_attr_map ipa_host_map[] = {
 struct sdap_attr_map ipa_hostgroup_map[] = {
     { "ipa_hostgroup_objectclass", "ipaHostgroup", SYSDB_HOSTGROUP_CLASS, NULL},
     { "ipa_hostgroup_name", "cn", SYSDB_NAME, NULL},
-    { "ipa_hostgroup_member", "member", SYSDB_MEMBER, NULL},
     { "ipa_hostgroup_memberof", "memberOf", SYSDB_ORIG_MEMBEROF, NULL},
     { "ipa_hostgroup_uuid", "ipaUniqueID", SYSDB_UUID, NULL},
     SDAP_ATTR_MAP_TERMINATOR
-- 
1.8.3.1



More information about the sssd-devel mailing list