[SSSD] [PATCH] Don't use srcdir with tests

Jakub Hrozek jhrozek at redhat.com
Thu Jun 20 08:21:11 UTC 2013


On Mon, Feb 04, 2013 at 04:34:16PM +0100, Jakub Hrozek wrote:
> On Fri, Feb 01, 2013 at 08:39:10AM -0500, Stephen Gallagher wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > On Fri 01 Feb 2013 05:45:25 AM EST, Jakub Hrozek wrote:
> > > On Thu, Jan 31, 2013 at 01:33:20PM -0500, Stephen Gallagher wrote:
> > >> -----BEGIN PGP SIGNED MESSAGE-----
> > >> Hash: SHA1
> > >>
> > >> On Thu 31 Jan 2013 01:06:06 PM EST, Jakub Hrozek wrote:
> > >>> Without this patch I can't build SSSD for rawhide as new autoconf
> > >>> versions error out when $(srcdir) is used in TESTS:
> > >>>
> > >>> Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken:
> > >>> '$(srcdir)/src/config/SSSDConfigTest.py'
> > >>> parallel-tests: installing 'build/test-driver'
> > >>> Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken:
> > >>> '$(srcdir)/src/tests/pyhbac-test.py'
> > >>> Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken:
> > >>> '$(srcdir)/src/tests/pysss_murmur-test.py'
> > >>>
> > >>>
> > >>> Not using srcdir is OK as the GNU manual states:
> > >>> "Automake ensures that each file listed in TESTS is built before it is
> > >>> run; you can list both source and derived programs (or scripts) in
> > >>> TESTS; the generated rule will look both in srcdir and .."
> > >>>
> > >>> This is an excerpt from:
> > >>> http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-Testsuites
> > >>>
> > >>
> > >> Can you check this against older versions of automake? I feel fairly
> > >> confident that this was an issue on Automake 1.9 and older.
> > >
> > > I was able to run "autoreconf -if; configure; make; make check" on both
> > > RHEL5 and RHEL6 with this patch.
> > 
> > Ok, ack
> 
> Pushed to master and sssd-1-9

I would like to also push this patch to sssd-1-5. Currently sssd-1-5
can't be even configured with recent Fedora toolchain.



More information about the sssd-devel mailing list