[SSSD] [PATCH] Fix dereference after a NULL check in tests.

Jakub Hrozek jhrozek at redhat.com
Mon Jun 10 10:43:46 UTC 2013


On Mon, Jun 10, 2013 at 11:56:30AM +0200, Lukas Slebodnik wrote:
> On (10/06/13 11:46), Jakub Hrozek wrote:
> >On Mon, Jun 10, 2013 at 10:53:15AM +0200, Lukas Slebodnik wrote:
> >> ehlo,
> >> 
> >> Do not call unlink with NULL pointer.
> >> 
> >> https://fedorahosted.org/sssd/ticket/1972
> >> Coverity IDs: 11870,11871
> >> 
> >> Patch is attached.
> >> 
> >> LS
> >
> >> From 0895c29c074526c4888758f06ba450a0e797e049 Mon Sep 17 00:00:00 2001
> >> From: Lukas Slebodnik <lslebodn at redhat.com>
> >> Date: Mon, 10 Jun 2013 10:23:44 +0200
> >> Subject: [PATCH] Fix dereference after a NULL check in tests.
> >> 
> >> https://fedorahosted.org/sssd/ticket/1972
> >> Coverity IDs: 11870,11871
> >> 
> >> Do not call unlink with NULL pointer.
> >
> >
> >> -    talloc_free(conf_db);
> >> -    talloc_free(sys_db);
> >> +cleanup:
> >> +    talloc_free(tmp_ctx);
> >
> >The code is fine but we usually name the labels "done" especially if
> >they can be reached on both success and failure.
> 
> I changed the label.
> 
> LS

Ack



More information about the sssd-devel mailing list