[SSSD] [PATCH] LDAP: Use domain-specific name where appropriate

Michal Židek mzidek at redhat.com
Wed Jul 24 11:40:45 UTC 2013


On 07/23/2013 09:30 PM, Jakub Hrozek wrote:
> On Tue, Jul 23, 2013 at 05:31:46PM +0200, Jakub Hrozek wrote:
>> On Tue, Jul 23, 2013 at 05:11:55PM +0200, Michal Židek wrote:
>>> On 07/23/2013 02:29 PM, Jakub Hrozek wrote:
>>>> The subdomain users user FQDN in their name attribute. However, handling
>>>> of whether to use FQDN in the LDAP code was not really good. This patch
>>>> introduces a utility function and converts code that was relying on
>>>> user/group names matching to this utility function.
>>>>
>>>> This is a temporary fix until we can refactor the sysdb API in #2011.
>>>>
>>>> Alexander, this patch fixed the username issues for me. I still see one
>>>> more problem -- on the first ID lookup, the user is reported as a member
>>>> of "Domain Users", but not on the subsequent lookups. This is unrelated
>>>> problem I'm looking into, but the attached patch is still correct.
>>>>
>>>>
>>>
>>> Nack.
>>>
>>> The function sdap_get_primary_name() is written for groups only.
>>> Variable names and debug messages are all group specific. Also
>>> the SDAP_AT_GROUP_NAME is used unconditionally inside of this function.
>>> It works, but only because SDAP_AT_GROUP_NAME and SDAP_AT_USER_NAME have
>>> the same value.
>>>
>>> I did some basic testing and the functionality looks good. I'll do more
>>> testing with the final patch where the above mentioned is fixed.
>>>
>>> Thanks
>>> Michal
>>
>> You're completely right, the function only worked by accident. Thanks.
>> New patch is attached.
>
> Michal nacked the patch in person once again. This time I was using
> "group" in DEBUG messages in a generic function. Hopefully I got it
> right this time.
>

Ack.

Thanks
Michal



More information about the sssd-devel mailing list