[SSSD] [PATCHES] Fix warnings

Lukas Slebodnik lslebodn at redhat.com
Fri Jul 19 13:36:22 UTC 2013


On (19/07/13 10:29), Jakub Hrozek wrote:
>On Thu, Jul 18, 2013 at 01:09:11PM +0200, Lukas Slebodnik wrote:
>> ehlo,
>> 
>> I tested some patches with old distro and I spotted warnings.
>>     -- uninitialized variable (gcc 4.4.7)
>>     -- macro AM_PROG_AR not found in library (automake 1.11.1)
>> 
>> I checked them and all warnings should be harmless, but anyway we don't like
>> warnings.
>> 
>> Two patches are attached.
>> 
>> LS
>
>Patch #1 really needs to be split into two, the Makefile.am/sssd.spec.in
>is a separate issue.
I removed changes to files Makefile.am/sssd.spec.in.
(I use those changes only internally.)

>
>Patch #2 looks OK to me, is the automake version you tested with (1.11.1)
>the one shipped on RHEL5?
RHEL6, master can not be built on RHEL5.

Updated patches are attached

LS
-------------- next part --------------
>From c4a4dbfc3474b47d185ceb1b240019ff51f3a643 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Thu, 18 Jul 2013 11:44:24 +0200
Subject: [PATCH 1/2] Fix warnings: uninitialized variable

---
 src/providers/krb5/krb5_child.c         | 3 +--
 src/providers/krb5/krb5_child_handler.c | 4 ++--
 src/sss_client/ssh/sss_ssh_client.c     | 2 +-
 src/util/usertools.c                    | 2 +-
 4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c
index e3dc0fcd8f9b89df324f3372ab0a2b24fe9e197a..50945c0c12562559ed6e62a9dcca9527bf600ce0 100644
--- a/src/providers/krb5/krb5_child.c
+++ b/src/providers/krb5/krb5_child.c
@@ -1820,8 +1820,7 @@ static krb5_error_code check_fast_ccache(TALLOC_CTX *mem_ctx,
     tmp_ctx = talloc_new(NULL);
     if (tmp_ctx == NULL) {
         DEBUG(1, ("talloc_new failed.\n"));
-        kerr = ENOMEM;
-        goto done;
+        return ENOMEM;
     }
 
     ccname = talloc_asprintf(tmp_ctx, "FILE:%s/fast_ccache_%s", DB_PATH, realm);
diff --git a/src/providers/krb5/krb5_child_handler.c b/src/providers/krb5/krb5_child_handler.c
index dda53ab1663f39ba8c5964d618b6f43763c83c88..044c27195a08b423cab2459915bf3488ba6ca885 100644
--- a/src/providers/krb5/krb5_child_handler.c
+++ b/src/providers/krb5/krb5_child_handler.c
@@ -486,7 +486,7 @@ parse_krb5_child_response(TALLOC_CTX *mem_ctx, uint8_t *buf, ssize_t len,
     errno_t ret;
     bool skip;
     char *ccname = NULL;
-    size_t ccname_len;
+    size_t ccname_len = 0;
     int32_t msg_status;
     int32_t msg_type;
     int32_t msg_len;
@@ -496,7 +496,7 @@ parse_krb5_child_response(TALLOC_CTX *mem_ctx, uint8_t *buf, ssize_t len,
     uint32_t *msg_subtype;
     struct krb5_child_response *res;
     const char *upn = NULL;
-    size_t upn_len;
+    size_t upn_len = 0;
     bool otp = false;
 
     if ((size_t) len < sizeof(int32_t)) {
diff --git a/src/sss_client/ssh/sss_ssh_client.c b/src/sss_client/ssh/sss_ssh_client.c
index 5312dba2be32aa0cc8813dedfc4189edeff7085c..245a0205685abfa553f6264942e97b3d556262bb 100644
--- a/src/sss_client/ssh/sss_ssh_client.c
+++ b/src/sss_client/ssh/sss_ssh_client.c
@@ -106,7 +106,7 @@ sss_ssh_get_ent(TALLOC_CTX *mem_ctx,
     errno_t ret;
     uint32_t flags;
     uint32_t name_len;
-    uint32_t alias_len;
+    uint32_t alias_len = 0;
     uint32_t domain_len;
     size_t req_len;
     uint8_t *req = NULL;
diff --git a/src/util/usertools.c b/src/util/usertools.c
index 7ec14b35118b8edb930314050339719539f0f7ff..9edae41e0f216f9f0d1660e473f3aa1bf7160b06 100644
--- a/src/util/usertools.c
+++ b/src/util/usertools.c
@@ -394,7 +394,7 @@ int sss_parse_name_for_domains(TALLOC_CTX *memctx,
                                const char *default_domain,
                                const char *orig, char **domain, char **name)
 {
-    struct sss_domain_info *dom, *match;
+    struct sss_domain_info *dom, *match = NULL;
     char *rdomain, *rname;
     char *dmatch, *nmatch;
     char *candidate_name = NULL;
-- 
1.8.3.1

-------------- next part --------------
>From ecb77a974413726591d373866e07467a72b415fb Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Thu, 18 Jul 2013 11:46:26 +0200
Subject: [PATCH 2/2] Fix autotols warnings: macro xyz not found in library

---
 configure.ac | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index b34ae3f4c98bd88e8f94550d4c3bdbab510602d7..b9b72e3d7cd3adf1bd127e6ae9546a460ee0055e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -16,8 +16,7 @@ AC_CONFIG_AUX_DIR([build])
 
 AM_INIT_AUTOMAKE([-Wall foreign subdir-objects tar-pax])
 AM_PROG_CC_C_O
-m4_pattern_allow([AM_PROG_AR])
-AM_PROG_AR
+m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
 AC_DISABLE_STATIC
 AC_PROG_INSTALL
 AC_PROG_LIBTOOL
@@ -33,8 +32,7 @@ AC_DEFINE([PRERELEASE_VERSION], "PRERELEASE_VERSION_NUMBER",
 
 AM_CONDITIONAL([GIT_CHECKOUT], [git log -1 &>/dev/null])
 
-m4_pattern_allow([AM_SILENT_RULES])
-AM_SILENT_RULES
+m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES])
 
 AM_CONDITIONAL([HAVE_GCC], [test "$ac_cv_prog_gcc" = yes])
 
-- 
1.8.3.1



More information about the sssd-devel mailing list