[SSSD] [PATCH] remove unused variable

Lukas Slebodnik lslebodn at redhat.com
Tue Jul 16 12:10:30 UTC 2013


On (16/07/13 13:31), Pavel Březina wrote:
>The recent patch that removes unused parameter nctx introduced an
>unused variable. I'm sorry for the fuss, I was missing -Werror in
>cflags and didn't noticed the warning before.

I attached first version of my patch and I did not noticed this.
but it means that your review was not very good :-)

LS

>From af30b2c1dfb3f521a6b47501fb3c28b33ad1f2b9 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina at redhat.com>
>Date: Tue, 16 Jul 2013 13:29:21 +0200
>Subject: [PATCH] remove unused variable
>
>---
> src/responder/nss/nsssrv_services.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/src/responder/nss/nsssrv_services.c b/src/responder/nss/nsssrv_services.c
>index 02c9466440263aca6268be754aca216fda6c8897..dccc2f40789ead31b8d76bf9a6c1f0e53334cfbb 100644
>--- a/src/responder/nss/nsssrv_services.c
>+++ b/src/responder/nss/nsssrv_services.c
>@@ -991,10 +991,6 @@ nss_cmd_getserv_done(struct tevent_req *req)
>     struct nss_dom_ctx *dctx =
>             tevent_req_callback_data(req, struct nss_dom_ctx);
>     struct nss_cmd_ctx *cmdctx = dctx->cmdctx;
>-    struct cli_ctx *cctx = cmdctx->cctx;
>-
>-    struct nss_ctx *nctx =
>-            talloc_get_type(cctx->rctx->pvt_ctx, struct nss_ctx);
> 
>     reqret = getserv_recv(dctx, req, &dctx->res);
>     talloc_zfree(req);
>-- 
>1.7.11.7
>

>_______________________________________________
>sssd-devel mailing list
>sssd-devel at lists.fedorahosted.org
>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel




More information about the sssd-devel mailing list