[SSSD] [PATCH] Return right directory name for dircache

Jakub Hrozek jhrozek at redhat.com
Wed Jul 10 21:20:46 UTC 2013


On Wed, Jul 10, 2013 at 07:15:01PM +0200, Lukas Slebodnik wrote:
> On (10/07/13 18:13), Jakub Hrozek wrote:
> >On Fri, Jun 28, 2013 at 05:07:29PM +0200, Lukas Slebodnik wrote:
> >> ehlo,
> >> 
> >> Dircache can be either file or directory. Wrong value was used
> >> when dircache was itself directory.
> >> 
> >> https://fedorahosted.org/sssd/ticket/2002
> >> 
> >> Patch is attached.
> >> 
> >> LS
> >This would work but maybe it would be easier to just take a look if
> >the ccache starts with "DIR:" or "DIR::" and avoid the stat..
> 
> lstat is called inside the function cc_residual_is_used, so we can safely avoid
> this.
> 
> Updated patch attached.
> 
> LS

Thank you, the code looks good to me and a user who ran into this
problem confirmed on IRC that the patch fixed the problem for him.

ACK.



More information about the sssd-devel mailing list