[SSSD] [PATCH] BUILD: Use pkg-config to detect cmocka

Stephen Gallagher sgallagh at redhat.com
Mon Jul 1 13:08:07 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/01/2013 09:02 AM, Lukas Slebodnik wrote:
> On (01/07/13 08:01), Stephen Gallagher wrote:
>> On 07/01/2013 04:46 AM, Lukas Slebodnik wrote:
>>> ehlo,
>>> 
>>> libcmocka-0.3 was released and package is available in fedore
>>> >= 18. libcmocka-devel contains pkg-config file, therefore it
>>> is better to use pkg-config to detect this library.
>>> 
>>> Patch is attached.
>>> 
>> 
>> I'd prefer if we tried the pkg-config approach first and then
>> fell back to the old detection form (since not all distributions
>> will get the 0.3 release at the same rate). Removing something
>> that works all of the time and replacing it with something that
>> only works some of the time is a net loss.
>> 
> 
> arch -- does not contain cmocka -- sssd is only in AUR and PKGBUILD
> require nor check or cmocka
> 
> debian/ubuntu does not contain cmocka
> 
> opensuse -- has cmocka only among unstable packages -- version 0.3
> is available
> 
> gentoo -- has cmocka (only 0.2) -- but sssd ebuild does not require
> it
> 
> cmocka is only optional dependency and this dependency was
> introduced in 1.10 development phase. I think this is the right
> time to use only pkg-config without any fall back.
> 

Ok, that's probably a fair statement.

Ack.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlHRfzcACgkQeiVVYja6o6NQqQCfdTUpnePlUwNvzC7zrt9q1C2v
okYAn33FmfBFOtPkLTQHmKtbs6uXugQZ
=f6Ud
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list