[SSSD] [PATCH] Don't use srcdir with tests

Jakub Hrozek jhrozek at redhat.com
Thu Jan 31 18:06:06 UTC 2013


Without this patch I can't build SSSD for rawhide as new autoconf
versions error out when $(srcdir) is used in TESTS:

Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken:
'$(srcdir)/src/config/SSSDConfigTest.py'
parallel-tests: installing 'build/test-driver'
Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken:
'$(srcdir)/src/tests/pyhbac-test.py'
Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken:
'$(srcdir)/src/tests/pysss_murmur-test.py'


Not using srcdir is OK as the GNU manual states:
"Automake ensures that each file listed in TESTS is built before it is
run; you can list both source and derived programs (or scripts) in
TESTS; the generated rule will look both in srcdir and .."

This is an excerpt from:
http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-Testsuites
-------------- next part --------------
>From 2cdcd10751f2e3f152124f698ae35d7947ca4771 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Thu, 31 Jan 2013 18:52:08 +0100
Subject: [PATCH] Don't use srcdir with tests

Fixes build with automake 1.13 or newer.
---
 Makefile.am | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 8a47af8ddb4eb274d390ec0bf3010736cb23b992..64708216103e48facf780f246de5668c8e0b26a7 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -146,9 +146,9 @@ check_PROGRAMS = \
 PYTHON_TESTS =
 
 if BUILD_PYTHON_BINDINGS
-PYTHON_TESTS += $(srcdir)/src/config/SSSDConfigTest.py \
-                $(srcdir)/src/tests/pyhbac-test.py \
-                $(srcdir)/src/tests/pysss_murmur-test.py
+PYTHON_TESTS += src/config/SSSDConfigTest.py \
+                src/tests/pyhbac-test.py \
+                src/tests/pysss_murmur-test.py
 endif
 
 TESTS = \
-- 
1.8.1



More information about the sssd-devel mailing list