[SSSD] [PATCH] ccache: recreate ccache if it was deleted

Stephen Gallagher sgallagh at redhat.com
Wed Jan 30 14:07:41 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed 30 Jan 2013 08:48:41 AM EST, Stephen Gallagher wrote:
> ********* *BEGIN ENCRYPTED or SIGNED PART* *********
>
> On 01/30/2013 08:05 AM, Pavel Březina wrote:
>> On 01/30/2013 01:20 PM, Jakub Hrozek wrote:
>>> On Wed, Jan 30, 2013 at 12:16:04PM +0100, Pavel Březina wrote:
>>>> On 01/30/2013 12:12 PM, Pavel Březina wrote:
>>>>> On 01/29/2013 03:55 PM, Pavel Březina wrote:
>>>>>> ccache: recreate ccache if it was deleted
>>>>>>
>>>>>> https://fedorahosted.org/sssd/ticket/1512
>>>>>
>>>>> Self nack.
>>>>>
>>>>> The previous version would recreate the ccache everytime,
>>>>> because kr->old_ccname is in TYPE:RESIDUAL format. I switched
>>>>> to krb5_cc_resolve().
>>>>>
>>>>> New patch is attached.
>>>>
>>>> One more self nack. I forgot to commit last change - move
>>>> comment to better place.
>>>>
>>>
>>> We discussed the patch with Pavel on IRC and thought it might be
>>> better to move the login to krb5_util to the check_existing
>>> functions. _______________________________________________
>>> sssd-devel mailing list sssd-devel at lists.fedorahosted.org
>>> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>>
>> Patch is attached.
>>
>>
>
> Minor correction:
> "does not exists" should be "does not exist".
>
> Otherwise, this looks good to me. No need to send for re-review, just
> fix it during push.
>
> I tested it by manually deleting /run/user/$UID/krb5cc and trying to
> log in. Without this patch, I get:
>
> (Wed Jan 30 08:42:51 2013) [[sssd[krb5_child[12399]]]]
> [create_ccache_in_dir] (0x0040): 495: [-1765328189][Credential cache
> directory /run/user/13041/krb5cc does not exist]
>
>
> After applying the patch, I can log in appropriately.
>
> Ack (with the above nitpick).

Since the original was already pushed, I pushed the attached minor
patch under the one-liner rule to both master and sssd-1-9.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlEJKS0ACgkQeiVVYja6o6P4EgCgoDQ7sqYB19za32hyIsk/yjEZ
2LAAn2ZcO0e0fseriVqfheRKz8p2H56j
=8NN5
-----END PGP SIGNATURE-----

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-minor-grammar-error-in-log.patch
Type: text/x-patch
Size: 980 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130130/408b048b/attachment.bin>


More information about the sssd-devel mailing list