[SSSD] [PATCH] Unchecked return value in files.c

Pavel Březina pbrezina at redhat.com
Mon Jan 28 09:37:19 UTC 2013


On 01/25/2013 07:10 PM, Michal Židek wrote:
> Found by Coverity. We check return value of closedir() on other places
> in the code, but here we don't.
>
> https://fedorahosted.org/sssd/ticket/1791
>
> Patch attached.
>
> Thanks
> Michal

Hi,
nack.

+                  ("Failed to close directory: %s.\n", strerror(ret)));
                                                                 ^ dret

We should also test the return value of close() on the succeeding
lines. I wonder why Coverity didn't argue here.



More information about the sssd-devel mailing list