[SSSD] [ding-libs patches] Cleanup patches in preparation for the 1.0 release

Dmitri Pal dpal at redhat.com
Wed Jan 23 14:34:42 UTC 2013


On 01/23/2013 09:14 AM, Dmitri Pal wrote:
> On 01/23/2013 07:32 AM, Ondrej Kos wrote:
>> On 23/12/12 20:18, Dmitri Pal wrote:
>>> Patch 1 https://fedorahosted.org/sssd/ticket/766
>>> Patch 2 https://fedorahosted.org/sssd/ticket/1276
>>> Patch 3 https://fedorahosted.org/sssd/ticket/1246
>>> Patch 4 https://fedorahosted.org/sssd/ticket/1532
>>
>> [PATCH 1/4]
>>
>> just a nitpick,
>>> +enum ERR_LEVEL {
>>> +    INI_STOP_ON_ANY   = 0, /**< Fail if any problem is detected. */
>>> +    INI_STOP_ON_NONE  = 1, /**< Best effort - do not fail. */
>>> +    INI_STOP_ON_ERROR = 2  /**< Fail on errors only. */
>>> +};
>> while using enum, it's unnecessary to enter values like this, when the
>> variables are in row
> Yes, I know. It is just my paranoia. Since it was in the defines
> explicitly I carried it forward.
> The nice benefit is that you always know which one is the last without
> the need to go a mental exercise.
>
>> [PATCH 2/4]
>>
>> Ack
>>
>> [PATCH 3/4]
>>
>> Ack
>>
>> [PATCH 4/4]
>>
>> trailing whitespace errors
>> On 23/12/12 20:18, Dmitri Pal wrote:
>>> Applying: Replacing sprintf with sprintf
>>> /home/okos/devel/ding-libs/.git/rebase-apply/patch:22: trailing
>>> whitespace.
>>>
>>> /home/okos/devel/ding-libs/.git/rebase-apply/patch:203: trailing
>>> whitespace.
>>>                 printf("This is unexpected error %d in mode %d\n",
>>> warning: 2 lines add whitespace errors.
>>>
>> Also, the patch name says "Replacing sprintf with sprintf", shouldn't
>> it be "Replacing sprintf with snprintf" ?
> I will address that and resend.
>> Otherwise, it's an Ack
>>
>>
>> Ondra
>>
>>
>
I updated the 4-th patch and regenarated the whole remaining set.
All 8 outstanding patches are attached.



-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager for IdM portfolio
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-INI-Converting-errors-to-enum.patch
Type: text/x-patch
Size: 3317 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130123/6f04c6ba/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-INI-More-interface-refactoring.patch
Type: text/x-patch
Size: 22946 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130123/6f04c6ba/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-INI-Introducing-parsing-flags.patch
Type: text/x-patch
Size: 16939 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130123/6f04c6ba/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-INI-Refactor-interface-a-bit.patch
Type: text/x-patch
Size: 16664 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130123/6f04c6ba/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-INI-Replacing-sprintf-with-snprintf.patch
Type: text/x-patch
Size: 18858 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130123/6f04c6ba/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-INI-Fixing-headers.patch
Type: text/x-patch
Size: 20540 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130123/6f04c6ba/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-INI-Use-ENOMEM-instead-of-errno.patch
Type: text/x-patch
Size: 6957 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130123/6f04c6ba/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-INI-Unit-test-for-parsing-flags.patch
Type: text/x-patch
Size: 4765 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130123/6f04c6ba/attachment-0007.bin>


More information about the sssd-devel mailing list