[SSSD] [PATCH] LDAP: Compare lists of DNs when saving autofs entries (sssd-1-9)

Jakub Hrozek jhrozek at redhat.com
Mon Jan 21 15:02:52 UTC 2013


On Mon, Jan 21, 2013 at 12:30:35PM +0100, Pavel Březina wrote:
> >>>>Hi,
> >>>>the patch does not apply to current master.
> >>>
> >>>See original mail:
> >>>"This patch applies on top of sssd-1-9"
> >>>
> >>>Originally I was trying to meet a deadline so I went with 1.9 first. But
> >>>you're right we need to fix the same problem in master, too. I will
> >>>prepare a version for master.
> >>
> >>Ah, my bad.
> >>
> >>Nack.
> >>
> >>get_autofs_entry_attr(): we should also check if el->num_values > 1 and
> >>error out if it happens.
> >>
> >
> >Well, I think it's better to try to carry, but the new patch simply
> >errors out if num_values != 1.
> >
> >>del_autofs_entries(): please, remove the FIXME :-) If you want to wrap
> >>it in sysdb function, it can be done in a minute. If you don't I don't
> >>mind in this case.
> >>
> >
> >OK, I moved the code into sysdb where it logically belongs.
> >
> >>sdap_autofs_setautomntent_save(): you don't use same_entries anywhere
> >
> >
> >Thanks, I was using it during debugging to see if the diff returns the
> >expected results and forgot to remove it.
> >
> >Thank you for the review, a new patch is attached. I also sent a patch
> >that applies on master with these comments factored in.
> 
> Ack.

Pushed to sssd-1-9 only



More information about the sssd-devel mailing list