[SSSD] [PATCHES] Second refactoring wave for #1747

Simo Sorce simo at redhat.com
Thu Jan 17 13:58:59 UTC 2013


On Thu, 2013-01-17 at 13:47 +0100, Jakub Hrozek wrote:
> On Sat, Jan 12, 2013 at 11:55:08AM -0500, Simo Sorce wrote:
> > Attached are 25 patches that are a second wave on top of my previous
> > refactoring patchset for #1747.
> > 
> > These new patches are a start for the removal of the sysdb argument from
> > some of the functions, leaving just the domain argument. This part is
> > not complete, but this subset is self contained.
> > 
> > On top of that there is also a complete refactoring of the code around
> > the struct be_req structure. This structure has now been made private to
> > the data_provider_be.c file so that it cannot be abused in future.
> > 
> > I will soon propose a third wave with more sysdb args elimination and
> > hopefully, finally a change in how subdomains are managed, which is the
> > end-goal of this long refactoring journey.
> > 
> > This patchset is also compressed as uncompresse dit amounts to ~ 250k
> 
> Hi Simo, I was only able to apply the first 10 patches, can you rebase
> (publishing just the git branch is OK).
> 
> I read the first 10 patches I could apply and they look good to me. I
> don't really have any issues and I give a tentative ack.
> 
> I ran some limited tests and didn't find any issues either, but I'd like
> to do full testing with the whole patchset.

I pushed a rebase sysdb_refactor tree with 2nd and third wave patches on
top of master.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list