[SSSD] [PATCH 0/2] [REBASE-3] Refactor krb5_child code

Pavel Březina pbrezina at redhat.com
Mon Jan 14 10:33:46 UTC 2013


On 01/12/2013 09:27 PM, Simo Sorce wrote:
> Rebased on top of current master.
>
> Simo.
>
> Simo Sorce (2):
>    krb5_child style fix
>    Refactor krb5 child
>
>   src/providers/krb5/krb5_child.c |  512 +++++++++++++++++----------------------
>   1 files changed, 217 insertions(+), 295 deletions(-)

Patch 1 ack.

Patch 2 nack:

src/providers/krb5/krb5_child.c: In function ‘main’:
src/providers/krb5/krb5_child.c:2013:8: warning: ‘ret’ may be used 
uninitialized in this function [-Wmaybe-uninitialized]

$ echo $CFLAGS
-m64 -mtune=generic -O3 -fstack-protector-all -Wall -Wextra 
-Wno-sign-compare -Wno-unused-parameter

Otherwise it seems good and working, but I'm not sure how to test FAST.
Anyone can help me?



More information about the sssd-devel mailing list