[SSSD] [PATCH] Add a default section to a swtich-statement

Sumit Bose sbose at redhat.com
Wed Jan 9 15:31:04 UTC 2013


On Wed, Jan 09, 2013 at 10:19:29AM -0500, Simo Sorce wrote:
> On Wed, 2013-01-09 at 08:45 -0500, Simo Sorce wrote:
> > On Wed, 2013-01-09 at 08:38 -0500, Simo Sorce wrote:
> > > On Wed, 2013-01-09 at 08:35 -0500, Simo Sorce wrote:
> > > > On Wed, 2013-01-09 at 11:37 +0100, Jakub Hrozek wrote:
> > > > > On Wed, Jan 09, 2013 at 11:31:53AM +0100, Jakub Hrozek wrote:
> > > > > > On Wed, Jan 09, 2013 at 10:51:34AM +0100, Sumit Bose wrote:
> > > > > > > Hi,
> > > > > > > 
> > > > > > > a switch statement which was introduced with "Remove unhelpful vtable
> > > > > > > from sss_cache" has a missing default section which results in a
> > > > > > > compiler warning about an uninitialized variable. The attached patch
> > > > > > > should fix it.
> > > > > > > 
> > > > > > > bye,
> > > > > > > Sumit
> > > > > > 
> > > > > > I don't see the warning even though I seem to be using very similar
> > > > > > CFLAGS to Sumit's. But the patch is correct, Ack.
> > > > > 
> > > > > I fixed a typo in the commit message (s/swtich/switch) and pushed to
> > > > > patch to master.
> > > > 
> > > > I will send a revert with the correct fix! :-(
> > > 
> > > Revert + fix case.
> > 
> > Actually I amended the patch to add a default of type_String = "unknown"
> > which will be (I hope) more explicative thana "(NULL)" in the log.
> 
> At Sumit's request another respin to also make the function static.

Thank you, ACK.

bye,
Sumit

> 
> Simo.
> 
> -- 
> Simo Sorce * Red Hat, Inc * New York



More information about the sssd-devel mailing list