[SSSD] [PATCH] LDAP: initialize refresh function handler

Jakub Hrozek jhrozek at redhat.com
Fri Jan 4 15:39:48 UTC 2013


On Wed, Jan 02, 2013 at 11:04:23AM +0100, Pavel Březina wrote:
> On 12/19/2012 04:54 PM, Ondrej Kos wrote:
> >On 19/12/12 12:45, Pavel Březina wrote:
> >>On 12/19/2012 10:27 AM, Ondrej Kos wrote:
> >>>i noticed warning during compilation:
> >>>
> >>>src/providers/ldap/sdap_sudo.c: In function
> >>>'sdap_sudo_schedule_refresh':
> >>>src/providers/ldap/sdap_sudo.c:1236:9: warning: 'send_fn' may be used
> >>>uninitialized in this function [-Wmaybe-uninitialized]
> >>>
> >>>patch is attached
> >>>
> >>>Ondra
> >>
> >>Hi,
> >>thanks. FYI you need at least -O1.
> >>
> >>I see also:
> >>src/providers/ldap/sdap_async_sudo.c: In function
> >>'sdap_sudo_load_sudoers_done':
> >>src/providers/ldap/sdap_async_sudo.c:579:9: warning: 'ret' may be used
> >>uninitialized in this function [-Wmaybe-uninitialized]
> >>src/providers/ldap/sdap_async_sudo.c:543:13: note: 'ret' was declared
> >>here
> >>
> >>Can you fix it too in this patch?
> >>_______________________________________________
> >>sssd-devel mailing list
> >>sssd-devel at lists.fedorahosted.org
> >>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >
> >thanks, i forgot to raise optimalization level after some debugging
> >
> >new patch is attached
> >
> >Ondra
> 
> Hi,
> nack. We don't want to initialize ret = EOK. We should set it after the
> for loop instead. But this touches the behaviour of this function so
> I'll send it as another patch.
> 
> Ack to the *original* patch.

Pushed the original patch to master and also sssd-1-9, compilation
warnings are ugly.



More information about the sssd-devel mailing list