[SSSD] [PATCH 0/4] Rev.2 - Create and use an auth token object

Simo Sorce simo at redhat.com
Thu Jan 3 15:16:02 UTC 2013


On Thu, 2013-01-03 at 11:03 +0100, Pavel Březina wrote:
> On 12/04/2012 02:30 PM, Simo Sorce wrote:
> > Fixed switch/case-return errors.
> > The rest is the same.
> >
> > Simo Sorce (4):
> >    Code can only check for cached passwords
> >    Add function to safely wipe memory.
> >    Add authtok utility functions.
> >    Change pam data auth tokens.
> >
> >   Makefile.am                                        |    4 +
> >   src/db/sysdb.h                                     |    3 +-
> >   src/db/sysdb_ops.c                                 |   13 +--
> >   src/providers/data_provider.h                      |    9 +-
> >   src/providers/dp_auth_util.c                       |   76 +++++---
> >   src/providers/dp_pam_data_util.c                   |  113 ++++++------
> >   src/providers/ipa/ipa_auth.c                       |    6 +-
> >   src/providers/krb5/krb5_auth.c                     |   55 +++---
> >   src/providers/krb5/krb5_child.c                    |  148 ++++++++-------
> >   src/providers/krb5/krb5_child_handler.c            |   59 +++++-
> >   .../krb5/krb5_delayed_online_authentication.c      |   50 +++--
> >   src/providers/krb5/krb5_renew_tgt.c                |   18 +--
> >   src/providers/ldap/ldap_auth.c                     |   90 ++++------
> >   src/providers/ldap/sdap_async.c                    |    4 +-
> >   src/providers/ldap/sdap_async.h                    |    7 +-
> >   src/providers/ldap/sdap_async_connection.c         |   88 +++++----
> >   src/providers/proxy/proxy.h                        |    7 +-
> >   src/providers/proxy/proxy_auth.c                   |   14 +-
> >   src/providers/proxy/proxy_child.c                  |   51 +++--
> >   src/responder/pam/pam_LOCAL_domain.c               |   52 ++---
> >   src/responder/pam/pamsrv_cmd.c                     |  159 +++++++++-------
> >   src/tests/krb5_child-test.c                        |   13 +-
> >   src/tests/sysdb-tests.c                            |    6 +-
> >   src/util/authtok.c                                 |  202 ++++++++++++++++++++
> >   src/util/authtok.h                                 |  180 +++++++++++++++++
> >   src/util/util.c                                    |    9 +
> >   src/util/util.h                                    |    9 +
> >   27 files changed, 958 insertions(+), 487 deletions(-)
> >   create mode 100644 src/util/authtok.c
> >   create mode 100644 src/util/authtok.h
> >
> > _______________________________________________
> > sssd-devel mailing list
> > sssd-devel at lists.fedorahosted.org
> > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >
> 
> Hi,
> I'm sorry, I still wasn't able to get through the whole 4th patch. It
> is really hard to keep track of those changes in 2000 line patch. Is it
> possible to split it somehow?

It would fail to compile. But the 4th patch should just be tedious
mechanical changes, is there something specific that distracts you ?
Maybe you can simply review a few files at a time ?

> Also I noticed that you used numbers instead of macro to specify debug
> level many times. Can you please switch to macros?

I didn't want to change anything I did not need to because the patch was
already big. I am not adding new debugging IIRC, just changing authtok
stuff, I thought changing debugging would just make the code more
burdensome to review.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list