[SSSD] sssd and ldb versions

Simo Sorce simo at redhat.com
Mon Feb 18 13:24:27 UTC 2013


On Mon, 2013-02-18 at 09:55 +0100, Jakub Hrozek wrote:
> On Sun, Feb 17, 2013 at 07:07:08PM +0100, Jan Engelhardt wrote:
> > Hi,
> > 
> > 
> > I am writing again with respect to the LDB matter
> > (https://lists.fedorahosted.org/pipermail/sssd-devel/2012-June/010303.html )
> > 
> > >There isn't really a workaround for it right now. The problem is that
> > >SSSD needs to build a plugin for LDB (our memberOf plugin) and because
> > >of a poor design decision in libldb, modules have to be rebuilt for
> > >every version number bump of the LDB library.
> > 
> > Samba people are letting it be known that sssd is part of the problem:
> > memberof.so has the following code piece:
> > 
> > 	int ldb_init_module(const char *version)                                        
> > 	{                                                                               
> > 	#ifdef LDB_MODULE_CHECK_VERSION                                                 
> > -->	    LDB_MODULE_CHECK_VERSION(version);                                          
> > 	#endif                                                                          
> > 	    return ldb_register_module(&ldb_memberof_module_ops);                       
> > 	}                                                                               
> > 
> > If sssd's memberof.so really did not care about ldb-1.1.x vs ldb-1.1.y,
> > then it probably should not call LDB_MODULE_CHECK_VERSION in the
> > first place.
> > 
> > (The samba part is at https://bugzilla.samba.org/show_bug.cgi?id=9495
> > comment 5.)
> 
> And Simo summarized our thoughts in comment #6. There is no guarantee
> that memberof won't randomly break.
> 
> I would be comfortable accepting the patch to remove the version check
> if there was some kind of automated way to run per-package tests in the
> Fedora build system. As far as I understand, only tests suitable for all
> packages (upgrade tests etc) are supported..
> 
> Would it help for consumers of SSSD and by extension memberof if we made
> the check configurable during configure time? Then people like Jan who
> explicitly don't want the version check in the distribution they are
> running can simply configure with --disable-ldb-version check perhaps.

Works for me.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list