[SSSD] [PATCH] Filter out multicast addresses from IPA DNS updates

Jakub Hrozek jhrozek at redhat.com
Fri Feb 8 18:41:52 UTC 2013


There was a ordering bug in the checker code. The address was in network
order, should have been converted to host order.
-------------- next part --------------
>From fc6499f562c1e3acee3b1298c0c2e98f32b33736 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Fri, 8 Feb 2013 19:39:24 +0100
Subject: [PATCH] Filter out multicast addresses from IPA DNS updates

https://fedorahosted.org/sssd/ticket/1804
---
 src/providers/ipa/ipa_dyndns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/providers/ipa/ipa_dyndns.c b/src/providers/ipa/ipa_dyndns.c
index 9d7a5b6ca966e1b2a058a05c8657d9f0fc80fa73..972f19ad1ab8c9f2e8a85cf686e6eba23332f92b 100644
--- a/src/providers/ipa/ipa_dyndns.c
+++ b/src/providers/ipa/ipa_dyndns.c
@@ -212,7 +212,7 @@ static bool ok_for_dns(struct sockaddr *sa)
             snprintf(straddr, INET6_ADDRSTRLEN, "unknown");
         }
 
-        if (IN_MULTICAST(addr->s_addr)) {
+        if (IN_MULTICAST(ntohl(addr->s_addr))) {
             DEBUG(SSSDBG_FUNC_DATA, ("Multicast IPv4 address %s\n", straddr));
             return false;
         } else if (inet_netof(*addr) == IN_LOOPBACKNET) {
-- 
1.8.1



More information about the sssd-devel mailing list