[SSSD] [PATCH] Don't use srcdir with tests

Stephen Gallagher sgallagh at redhat.com
Fri Feb 1 13:39:10 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri 01 Feb 2013 05:45:25 AM EST, Jakub Hrozek wrote:
> On Thu, Jan 31, 2013 at 01:33:20PM -0500, Stephen Gallagher wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On Thu 31 Jan 2013 01:06:06 PM EST, Jakub Hrozek wrote:
>>> Without this patch I can't build SSSD for rawhide as new autoconf
>>> versions error out when $(srcdir) is used in TESTS:
>>>
>>> Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken:
>>> '$(srcdir)/src/config/SSSDConfigTest.py'
>>> parallel-tests: installing 'build/test-driver'
>>> Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken:
>>> '$(srcdir)/src/tests/pyhbac-test.py'
>>> Makefile.am:149: error: using '$(srcdir)' in TESTS is currently broken:
>>> '$(srcdir)/src/tests/pysss_murmur-test.py'
>>>
>>>
>>> Not using srcdir is OK as the GNU manual states:
>>> "Automake ensures that each file listed in TESTS is built before it is
>>> run; you can list both source and derived programs (or scripts) in
>>> TESTS; the generated rule will look both in srcdir and .."
>>>
>>> This is an excerpt from:
>>> http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-Testsuites
>>>
>>
>> Can you check this against older versions of automake? I feel fairly
>> confident that this was an issue on Automake 1.9 and older.
>
> I was able to run "autoreconf -if; configure; make; make check" on both
> RHEL5 and RHEL6 with this patch.

Ok, ack
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlELxX4ACgkQeiVVYja6o6OQ7gCfSm5dc2w9Qf2ZmfSnxnBiKbls
7HAAoKWk21A9yHvPjxO8ZF69U0GBQa2T
=SQcx
-----END PGP SIGNATURE-----




More information about the sssd-devel mailing list