[SSSD] [PATCH 3/4] Make DEBUG macro variadic

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Wed Dec 18 18:20:05 UTC 2013


Hi Stephen,

On 12/18/2013 07:55 PM, Stephen Gallagher wrote:
> Nikolai, has there been any progress on this? I'd actually really like
> to see these changes land, as they'll make my life easier as I work on
> journald support for the debug logs.
>
> What I'm looking for is mostly the variadic change (so that we don't
> have to pass the ("message") into the DEBUG macro. However, I suppose
> that if we're going to be mass-changing them anyway, it makes sense to
> update the level designations at the same time.

I found out that Coccinelle was unfortunately unsuitable for the job as it got
confused by complicated code involving macros (popt was one of the culprits)
and aborted processing of some files silently (!). And it was doing such a
good job otherwise. Sigh. So the best bet is Perl, unfortunately.

Since that setback I got sucked into other matters, but I still have the
scripts which worked quite well. I might resume that work this week and see if
they still do.

Sincerely,
Nick



More information about the sssd-devel mailing list