[SSSD] [PATCH] AD: use LDAP for group lookups

Sumit Bose sbose at redhat.com
Fri Dec 13 07:57:48 UTC 2013


On Thu, Dec 12, 2013 at 09:57:38PM +0100, Jakub Hrozek wrote:
> On Wed, Dec 11, 2013 at 03:12:13PM +0100, Sumit Bose wrote:
> > Hi,
> > 
> > this patch should fix the issues related to group-memberships in the AD
> > provider. The aim was to fix https://fedorahosted.org/sssd/ticket/2161
> > but since now the group lookups are done against LDAP
> > https://fedorahosted.org/sssd/ticket/2148 should be fixed as well.
> > 
> > bye,
> > Sumit
> 
> Hi,
> 
> thank you, these patches work nicely. I think I can ACK them now, I'll
> just run them through Coverity to make sure there are no new warnings.

+1 for Coverity

> 
> I only wonder if there is any looming code duplication between this
> module and the helpers in ad_common.c? It's not urgent to solve now,
> though.

ad_subdom_ad_ctx_new() is "inspired" by ipa_ad_ctx_new(). But since this
patch is aiming for a minor release I didn't want to break
ipa_ad_ctx_new() by refactoring it. But yes, there is a duplication.

bye,
Sumit

> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel



More information about the sssd-devel mailing list