[SSSD] Warn to syslog if an unresponsive subprocess is terminated

Jakub Hrozek jhrozek at redhat.com
Thu Dec 5 12:55:59 UTC 2013


On Wed, Dec 04, 2013 at 12:30:39PM -0500, Dmitri Pal wrote:
> >> +    te = tevent_add_timer(svc->mt_ctx->ev, svc, tv, mt_svc_sigkill, svc);
> >> +    if (te == NULL) {
> >> +        /* Nothing much we can do */
> >> +        ret = ENOMEM;
> >> +        DEBUG(SSSDBG_CRIT_FAILURE, ("Out of memory?!\n"));
> >> +        talloc_free(svc);
> > I agree with removing the sigkill_ev, but I would prefer if the function
> > either returned ENOMEM here directly or jumped to return. I think the
> > fallthrough is potentially dangerous.
> 
> 
> Can we also just in general be more explicit. May be use something like:
> "Out of memory trying to allocate X to do Y"

Yes, but in Pavel's defense, he just moved an existing message around.



More information about the sssd-devel mailing list