[SSSD] [PATCH 1/2] sysv/gentoo: Use xdm if possible

Jakub Hrozek jhrozek at redhat.com
Wed Dec 4 16:03:25 UTC 2013


On Mon, Dec 02, 2013 at 09:23:53PM +0100, Jakub Hrozek wrote:
> On Mon, Dec 02, 2013 at 09:21:22PM +0100, Jakub Hrozek wrote:
> > On Mon, Dec 02, 2013 at 06:37:07PM +0000, Markos Chandras wrote:
> > > Allow sssd to use the xdm wrapper so login managers can
> > > use sssd to authenticate users.
> > > 
> > > Signed-off-by: Markos Chandras <hwoarang at gentoo.org>
> > > ---
> > >  src/sysv/gentoo/sssd.in | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/src/sysv/gentoo/sssd.in b/src/sysv/gentoo/sssd.in
> > > index 8007b64..fd5d745 100644
> > > --- a/src/sysv/gentoo/sssd.in
> > > +++ b/src/sysv/gentoo/sssd.in
> > > @@ -2,7 +2,7 @@
> > >  
> > >  depend(){
> > >      need localmount netmount clock
> > > -    use syslog
> > > +    use syslog xdm
> > 
> >                   ^^^
> > As explained in https://fedorahosted.org/sssd/ticket/2165, xdm is
> > provided by any login manager in Gentoo, so this change is not
> > xdm-specific.
> > 
> > >  }
> > >  
> > >  start(){
> > > -- 
> > > 1.8.4.4
> > 
> > Hi Markos,
> > 
> > thanks for sending the distribution patches upstream, much appreciated!
> > 
> > I ran just the basic sanity tests with the patch. It applies, make, make
> > check and make distcheck passes. I don't have any Gentoo machine around,
> > but I trust Markos given he's the Gentoo maintainer. Also the patches
> > are applied in Gentoo anyway:
> > http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-auth/sssd/files/sssd-1.9.6-fix-init.patch?view=markup
> > 
> > So ACK from me. I'll leave the patches on the list until tomorrow in
> > case other developers would like to voice any concerns, then I'll push
> > them. Given the non-destructive nature of the patch
> 
> Oops, hit send too soon. Given the non-destructive nature of the patch,
> I'm fine pushing the patch to stable braches as well, not just master.

Pushed to master and sssd-1-11

Thanks for the contribution, Markos!



More information about the sssd-devel mailing list