[SSSD] [PATCH] USe rkb5.conf default for ccache template

Simo Sorce simo at redhat.com
Tue Aug 27 20:42:35 UTC 2013


On Tue, 2013-08-27 at 15:22 -0400, Simo Sorce wrote:
> On Tue, 2013-08-27 at 14:05 -0400, Stephen Gallagher wrote:
> > Patch 0002: Nack
> > 
> > As discussed on IRC, please split out the patch that removes the
> > contrib patch into a separate patch in the set and modify it so that
> > it reverts to using the built-in defaults (which means updating the
> > sssd.spec.in as well).
> 
> Ah I had all in one patch, splitting ...
> 
> > In sss_get_system_ccname_template(), you fail to check the result of
> > the talloc_strdup(). Also, by convention you should have an explicit
> > ret = EOK in the success case just before the done: label.
> 
> It was actually intentional, but your comment made me think that we
> probably want to fail if the strdup fails, changed.
> 
> > Wouldn't it make more sense to return ENOENT than a NULL ccname? from
> > sss_get_system_ccname_template()? It's not critical, but we tend to
> > use that approach in the rest of the code. It would be more clear in
> > the code what you're doing here too. I had to read it again after
> > reading the consuming function to understand it properly.
> 
> I was a bit doubtful because ENOENT always result ina "File not found
> error" which is quite misleading. So I added a new sssd error of
> ERR_NOT_FOUND, hpe this is ok.

And now with the right patches.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-krb5_common-Refactor-to-use-a-talloc-temp-context.patch
Type: text/x-patch
Size: 4043 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130827/dd19d69f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-krb5-Fetch-ccname-template-from-krb5.conf.patch
Type: text/x-patch
Size: 16775 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130827/dd19d69f/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-BUILD-Remove-unnecessary-patch-and-configure-opts.patch
Type: text/x-patch
Size: 3579 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130827/dd19d69f/attachment-0002.bin>


More information about the sssd-devel mailing list