[SSSD] [PATCHES] Enable printf format string checking

Stephen Gallagher sgallagh at redhat.com
Wed Aug 21 11:57:39 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/21/2013 07:46 AM, Jakub Hrozek wrote:

>> Subject: [PATCH 10/16] Fix formating of variables with type:
>> key_serial_t Subject: [PATCH 11/16] Fix formating of variables
>> with type: rlim_t Subject: [PATCH 12/16] Fix formating of
>> variables with type defined in stdint.h
> 
> Nice, I didn't know these existed. But to be honest, these format
> specifiers seem ugly to me..wouldn't it be nicer to cast the
> variables to a larger type (long or unsigned long) and then use
> plan C conversion?
> 

I think I disagree here. I'd rather see us using explicit values. It
leaves less room for mistakes on different platforms.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlIUqzMACgkQeiVVYja6o6NMMQCaA78YCZJrht7FL93kFLesRYC8
ALkAn1MEk9IK4UpqrM4KbSK+dja0p4Gb
=5B53
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list