[SSSD] [PATCH] proxy: Alocate auth tokens in struct authtok_conv

Jakub Hrozek jhrozek at redhat.com
Mon Aug 19 08:13:49 UTC 2013


On Wed, Aug 14, 2013 at 04:38:39PM -0400, Simo Sorce wrote:
> On Wed, 2013-08-14 at 17:57 +0200, Lukas Slebodnik wrote:
> > On (14/08/13 11:46), Simo Sorce wrote:
> > >On Wed, 2013-08-14 at 13:50 +0200, Lukas Slebodnik wrote:
> > >> ehlo,
> > >> 
> > >> Struct sss_auth_token became opaque in commit
> > >> 9acfb09f7969a69f58bd45c856b01700541853ca.
> > >> All ocasions of "struct sss_auth_token" was replaced with pointer to this
> > >> structure, but proper initialization of auth_tokens was missing
> > >> in struct authtok_conv.
> > >> 
> > >> Patch is attached.
> > >
> > >NACK
> > >You call free() on a talloced structure.
> > >You want to call talloc_free() there.
> > of course
> > >
> > >Otherwise LGTM.
> > >
> > >Simo.
> > >
> > 
> > Thank you for review. It was copy&paste problem.
> > Updated patch is attached.
> 
> 
> Ack,
> Simo.

Pushed to master and sssd-1-10



More information about the sssd-devel mailing list