[SSSD] [PATCH] Two krb5 small child fixes

Jakub Hrozek jhrozek at redhat.com
Sun Aug 18 19:46:56 UTC 2013


[PATCH 1/2] KRB5: Formatting changes
Trivial formatting patch

[PATCH 2/2] KRB5: Do not log to syslog on each login
Only log on failures, not each login. I don't think admins of busy
servers would appreciate a syslog message per login.
-------------- next part --------------
>From 5e378cc9d4b45ba97f7de9f7eca9dc115cb9249f Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Sun, 18 Aug 2013 20:27:10 +0200
Subject: [PATCH 1/2] KRB5: Formatting changes

---
 src/providers/krb5/krb5_child.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c
index b77fa0aa5ed3c8750bc9dccf2a160818a845cf3b..2516e46633ac5d2cd56b9731c5e7ba0ba0eaeb2b 100644
--- a/src/providers/krb5/krb5_child.c
+++ b/src/providers/krb5/krb5_child.c
@@ -447,7 +447,7 @@ static bool need_switch_to_principal(krb5_context ctx, krb5_principal princ)
     bool ret = false;
 
     kerr = krb5_cc_default(ctx, &default_cc);
-    if (kerr !=0) {
+    if (kerr != 0) {
         KRB5_CHILD_DEBUG(SSSDBG_TRACE_INTERNAL, kerr);
         goto done;
     }
@@ -463,13 +463,13 @@ static bool need_switch_to_principal(krb5_context ctx, krb5_principal princ)
     }
 
     kerr = krb5_unparse_name(ctx, default_princ, &default_full_name);
-    if (kerr !=0) {
+    if (kerr != 0) {
         KRB5_CHILD_DEBUG(SSSDBG_TRACE_INTERNAL, kerr);
         goto done;
     }
 
     kerr = krb5_unparse_name(ctx, princ, &full_name);
-    if (kerr !=0) {
+    if (kerr != 0) {
         KRB5_CHILD_DEBUG(SSSDBG_TRACE_INTERNAL, kerr);
         goto done;
     }
@@ -2042,7 +2042,7 @@ static int k5c_setup(struct krb5_req *kr, uint32_t offline)
 
     if (debug_level & SSSDBG_TRACE_ALL) {
         kerr = sss_child_set_krb5_tracing(kr->ctx);
-        if (kerr) {
+        if (kerr != 0) {
             KRB5_CHILD_DEBUG(SSSDBG_MINOR_FAILURE, kerr);
             return EIO;
         }
-- 
1.8.3.1

-------------- next part --------------
>From 280a34e87e371188f0612dd890f51c9a654435fb Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Sun, 18 Aug 2013 20:26:59 +0200
Subject: [PATCH 2/2] KRB5: Do not log to syslog on each login

---
 src/providers/krb5/krb5_child.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c
index 2516e46633ac5d2cd56b9731c5e7ba0ba0eaeb2b..4ba0f366078cd00bf0d935757f902ff3d64e6f04 100644
--- a/src/providers/krb5/krb5_child.c
+++ b/src/providers/krb5/krb5_child.c
@@ -1235,7 +1235,9 @@ done:
 
 static errno_t map_krb5_error(krb5_error_code kerr)
 {
-    KRB5_CHILD_DEBUG(SSSDBG_CRIT_FAILURE, kerr);
+    if (kerr != 0) {
+        KRB5_CHILD_DEBUG(SSSDBG_CRIT_FAILURE, kerr);
+    }
 
     switch (kerr) {
     case 0:
-- 
1.8.3.1



More information about the sssd-devel mailing list