[SSSD] [PATCH] AD: Cast SASL callbacks to propper type

Pavel Březina pbrezina at redhat.com
Wed Aug 7 22:15:06 UTC 2013


On 08/07/2013 03:40 PM, Ondrej Kos wrote:
> Hi,
>
> While working on another issue, I noticed a warning in recently added
> code (commit fb945a2c). On F18 the build works fine, but not on F19.
> This is caused by the change of cyrus-sasl API, they changed the
> *sasl_callback_t* callback member from
> int (*proc)();
> to
> int (*proc)(void);
>
> Attached patch adds typedef for propper cast and fixes the issue.
>
> Ondra

Hi,
minor nack. Please append _t to the name to imply it's a #typedef and 
prefix it with sss_ to avoid possible conflict with future sasl API.




More information about the sssd-devel mailing list