[SSSD] [PATCH] Only try to relink ghost users if we're not enumerating

Lukas Slebodnik lslebodn at redhat.com
Mon Apr 29 15:54:52 UTC 2013


On (29/04/13 16:39), Jakub Hrozek wrote:
>On Mon, Apr 29, 2013 at 03:46:25PM +0200, Jakub Hrozek wrote:
>> On Mon, Apr 29, 2013 at 03:10:33PM +0200, Jakub Hrozek wrote:
>> > On Mon, Apr 29, 2013 at 03:03:14PM +0200, Jakub Hrozek wrote:
>> > > https://fedorahosted.org/sssd/ticket/1893
>> > > 
>> > > When SSSD is not enumerating (which is the default), we are trying to
>> > > link any "ghost" entries with a newly created user entry. However, when
>> > > enumeration is on, this means a spurious search on adding any user.
>> > 
>> > btw much of the credit goes to Lukas who bisected the code and was able
>> > to pinpoint the commit that broke the enumeration performance.
>> 
>> Self-nack, the patch breaks the sysdb unit tests.
>
>New patches attached for both master and sssd-1-9.

Both patches fix bug in ticket 1893.
Ack

Just one nitpick bellow. (in both patches)

>+        /* If we're not enumerating, previous getgr{nam,gid} calls might
>+         * have stored ghost users into the cache, so we need to link them
>+         * with the newly-created user entry */
                                              ^^^^
                         It should be on the next line.

LS



More information about the sssd-devel mailing list