[SSSD] [PATCH] Fix segmentation fault in test_io.

Jakub Hrozek jhrozek at redhat.com
Wed Apr 24 19:35:40 UTC 2013


On Mon, Apr 22, 2013 at 05:29:05PM +0530, Abhishek Singh wrote:
> changes done. Please check the patch.
> 

Looks good to me now.

Ack!

> 
> On Mon, Apr 22, 2013 at 12:55 PM, Jakub Hrozek <jhrozek at redhat.com> wrote:
> 
> > On Tue, Apr 16, 2013 at 07:27:20PM +0530, Abhishek Singh wrote:
> > > Changes done. Please check the patch.
> > >
> > > thanks,
> > >
> >
> > Hi Abishek
> >
> > let's do one last change before I push the patch -- test the strdup
> > output for being non-NULL and then free the duplicate when it's not
> > needed:
> >
> >     basec = strdup(get_filepath(path));
> > +   assert_non_null(basec);
> >     relativepath = basename(basec);
> >     fd = sss_openat_cloexec(dir_fd, relativepath, flags, &ret);
> > +   free(basec)
> >
> >
> > Thanks for the patch!
> >





More information about the sssd-devel mailing list