[SSSD] [PATCH] Two man page patches

Jakub Hrozek jhrozek at redhat.com
Tue Apr 23 15:35:17 UTC 2013


On Tue, Apr 23, 2013 at 02:30:48PM +0200, Michal Židek wrote:
> On 04/19/2013 03:42 PM, Jakub Hrozek wrote:
> >+                                A domain name should only consist of alphanumeric
> >+                                characters, dashes and underscores.
> 
> One more nitpick. Instead of just "alphanumeric characters" it might
> be better to use "ASCII alphanumeric characters", so that it is
> clear, that locale specific alphanumeric  characters are not
> supported.
> 
> Sorry for not catching this in the first iteration.
> 
> Michal

Thanks for the review, new patches are attached.
-------------- next part --------------
>From 76a849974f7dbe7705bf8161c2e81f5d20a92dcf Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Thu, 18 Apr 2013 14:15:01 +0200
Subject: [PATCH 1/2] Document the naming convention for SSSD domains

https://fedorahosted.org/sssd/ticket/1809
---
 src/man/sssd.conf.5.xml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
index 6a1292c6c8b9ed2c0550971b2969ff71431b5701..04c699948b093c235762c0d9f8223911a6fd2ada 100644
--- a/src/man/sssd.conf.5.xml
+++ b/src/man/sssd.conf.5.xml
@@ -117,6 +117,8 @@
                                 must be configured or SSSD won't start.
                                 This parameter described the list of domains
                                 in the order you want them to be queried.
+                                A domain name should only consist of alphanumeric
+                                ASCII characters, dashes and underscores.
                             </para>
                         </listitem>
                     </varlistentry>
-- 
1.8.1.4

-------------- next part --------------
>From cfec1031e147f481ee6b9b7ad55b2400bdcc277a Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Thu, 18 Apr 2013 14:17:40 +0200
Subject: [PATCH 2/2] Document that the AD provider is case-insensitive

https://fedorahosted.org/sssd/ticket/1867
---
 src/man/sssd-ad.5.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/man/sssd-ad.5.xml b/src/man/sssd-ad.5.xml
index 3b2b0bc0bc9e68230329aab6759e6b807bdf0735..d0d55146c5e0ba1ec1c77afce137b469d77c7e28 100644
--- a/src/man/sssd-ad.5.xml
+++ b/src/man/sssd-ad.5.xml
@@ -68,6 +68,7 @@
             <programlisting>
 ldap_id_mapping = False
             </programlisting>
+            The AD provider is also always case-insensitive.
         </para>
     </refsect1>
 
-- 
1.8.1.4



More information about the sssd-devel mailing list