[SSSD] [PATCH] Active Directory dynamic DNS updates

Pavel Březina pbrezina at redhat.com
Mon Apr 22 12:20:59 UTC 2013


On 04/17/2013 09:04 PM, Jakub Hrozek wrote:
> https://fedorahosted.org/sssd/ticket/1504
>
> Implements dynamic DNS updates for the AD provider. By default, the
> updates also update the reverse zone and run periodically every 24
> hours.

Hi,
I will do more thorough review in next days, but there are two thing
that struck in my eyes.

> 0001-Active-Directory-dynamic-DNS-updates.patch
>
>
> From 5306abceba7e6eed97763a0cd48bb886ff161835 Mon Sep 17 00:00:00
> 2001 From: Jakub Hrozek<jhrozek at redhat.com> Date: Tue, 16 Apr 2013
> 17:04:43 +0200 Subject: [PATCH] Active Directory dynamic DNS updates
>
> https://fedorahosted.org/sssd/ticket/1504
>
> Implements dynamic DNS updates for the AD provider. By default, the
> updates also update the reverse zone and run periodically every 24
> hours.

> --- a/src/man/sssd-ad.5.xml +++ b/src/man/sssd-ad.5.xml

Please, move dyndns options into a separate xml and include it into
sssd-ad and sssd-ipa.

ad_dyndns.c and ipa_dyndns.c are *very* similar. It must be possible to
write this code only ones. Do you have any specific reasons why haven't
you done so?



More information about the sssd-devel mailing list