[SSSD] [PATCH] Make leak checks usable in tests that do not utilize check

Jakub Hrozek jhrozek at redhat.com
Wed Apr 17 11:37:52 UTC 2013


On Tue, Apr 16, 2013 at 09:03:33AM +0200, Lukas Slebodnik wrote:
> On (15/04/13 16:39), Jakub Hrozek wrote:
> >On Thu, Apr 11, 2013 at 05:06:21PM +0200, Lukas Slebodnik wrote:
> >> On (11/04/13 15:08), Lukas Slebodnik wrote:
> >> >On (11/04/13 09:52), Jakub Hrozek wrote:
> >> >>I am using the leak check to make sure the dyndns requests do not leak,
> >> >>but the leak checks were only usable in conjunction with check. This
> >> >>patch does the following:
> >> >>
> >> >>* Remove check-specific failure reporting from common_check.c
> >> >>* Add check-specific abstraction over memleak checks
> >> >>* Rename common_check.c to leak_check.c
> >> >
> >> >I tried to simulate memory leak. And it works like expected.
> >> >
> >> >Ack
> >> >
> >> >LS
> >> 
> >> After off list discussion. We find out, that Jakub squashs changes
> >> from resolv-tests.c to another commit.
> >> 
> >> $git grep -En 'check_leaks_(push|pop)'
> >> resolv-tests.c:121:    check_leaks_push(ctx);
> >> resolv-tests.c:154:    check_leaks_pop(ctx);
> >> resolv-tests.c:206:    check_leaks_push(test_ctx);
> >> resolv-tests.c:220:    check_leaks_pop(test_ctx);
> >> resolv-tests.c:275:    check_leaks_push(test_ctx);
> >> resolv-tests.c:289:    check_leaks_pop(test_ctx);
> >> resolv-tests.c:331:    check_leaks_push(test_ctx);
> >> resolv-tests.c:345:    check_leaks_pop(test_ctx);
> >> resolv-tests.c:369:    check_leaks_push(tmp_ctx);
> >> resolv-tests.c:420:    check_leaks_pop(tmp_ctx);
> >> resolv-tests.c:437:    check_leaks_push(test_ctx);
> >> resolv-tests.c:452:    check_leaks_pop(test_ctx);
> >> resolv-tests.c:467:    check_leaks_push(test_ctx);
> >> resolv-tests.c:476:    check_leaks_pop(test_ctx);
> >> resolv-tests.c:492:    check_leaks_push(test_ctx);
> >> resolv-tests.c:501:    check_leaks_pop(test_ctx);
> >> resolv-tests.c:603:    check_leaks_push(test_ctx);
> >> resolv-tests.c:670:    check_leaks_pop(test_ctx);
> >> resolv-tests.c:690:    check_leaks_push(test_ctx);
> >> resolv-tests.c:719:    check_leaks_pop(test_ctx);
> >> resolv-tests.c:740:    check_leaks_push(tmp_ctx);
> >> resolv-tests.c:748:    check_leaks_pop(tmp_ctx);
> >> 
> >> LS
> >
> >Thanks for the review, a new patch is attached.
> 
> Ack
> 
> LS

Pushed to master.



More information about the sssd-devel mailing list